Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners: fix default value for stop_sequences in ChatGroq #28924

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

dabzr
Copy link
Contributor

@dabzr dabzr commented Dec 26, 2024

  • Description:
    This PR addresses an issue with the stop_sequences field in the ChatGroq class. Currently, the field is defined as:
stop: Optional[Union[List[str], str]] = Field(None, alias="stop_sequences")

This causes the language server (LSP) to raise an error indicating that the stop_sequences parameter must be implemented. The issue occurs because Field(None, alias="stop_sequences") is different compared to Field(default=None, alias="stop_sequences").

image
To resolve the issue, the field is updated to:

stop: Optional[Union[List[str], str]] = Field(default=None, alias="stop_sequences")

While this issue does not affect runtime behavior, it ensures compatibility with LSPs and improves the development experience.

  • Issue: N/A
  • Dependencies: None

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 26, 2024
Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 3:21am

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Dec 26, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 26, 2024
@ccurme ccurme merged commit ffbe5b2 into langchain-ai:master Dec 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants